This is an archive of the discontinued LLVM Phabricator instance.

Differential D30515

Made GetClangTargetCPU() const.
ClosedPublic

Authored by jmajors on Mar 1 2017, 4:25 PM.

Details

Reviewers
eugene
labath
Commits
rG0a0d354ee69f: Made GetClangTargetCPU() const.
rLLDB296868: Made GetClangTargetCPU() const.
rL296868: Made GetClangTargetCPU() const.
Summary

It does not change members or call non-const members.
HostInfo::GetArchitecture() returns a const object ref (maybe others?),
which can't access the non-const function.

Diff Detail

Event Timeline

jmajors created this revision.Mar 1 2017, 4:25 PM
eugene accepted this revision.Mar 1 2017, 4:44 PM
This revision is now accepted and ready to land.Mar 1 2017, 4:44 PM
labath accepted this revision.Mar 2 2017, 1:48 AM
Closed by commit rL296868: Made GetClangTargetCPU() const. (authored by labath). · Explain WhyMar 3 2017, 5:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
lldb/
Core/
2 lines
source/
Core/
2 lines

Diff 90255

include/lldb/Core/ArchSpec.h

Show First 20 Lines • Show All 301 Lines • ▼ Show 20 Linespublic:
//------------------------------------------------------------------ //------------------------------------------------------------------
/// Returns a string representing current architecture as a target CPU /// Returns a string representing current architecture as a target CPU
/// for tools like compiler, disassembler etc. /// for tools like compiler, disassembler etc.
/// ///
/// @return A string representing target CPU for the current /// @return A string representing target CPU for the current
/// architecture. /// architecture.
//------------------------------------------------------------------ //------------------------------------------------------------------
std::string GetClangTargetCPU(); std::string GetClangTargetCPU() const;
//------------------------------------------------------------------ //------------------------------------------------------------------
/// Return a string representing target application ABI. /// Return a string representing target application ABI.
/// ///
/// @return A string representing target application ABI. /// @return A string representing target application ABI.
//------------------------------------------------------------------ //------------------------------------------------------------------
std::string GetTargetABI() const; std::string GetTargetABI() const;
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines

source/Core/ArchSpec.cpp

Show First 20 Lines • Show All 651 Lines • ▼ Show 20 Lines if (IsMIPS()) {
else if (elf_abi == "n32") else if (elf_abi == "n32")
flag |= ArchSpec::eMIPSABI_N32; flag |= ArchSpec::eMIPSABI_N32;
else if (elf_abi == "o32") else if (elf_abi == "o32")
flag |= ArchSpec::eMIPSABI_O32; flag |= ArchSpec::eMIPSABI_O32;
} }
SetFlags(flag); SetFlags(flag);
} }
std::string ArchSpec::GetClangTargetCPU() { std::string ArchSpec::GetClangTargetCPU() const {
std::string cpu; std::string cpu;
const llvm::Triple::ArchType machine = GetMachine(); const llvm::Triple::ArchType machine = GetMachine();
if (machine == llvm::Triple::mips || machine == llvm::Triple::mipsel || if (machine == llvm::Triple::mips || machine == llvm::Triple::mipsel ||
machine == llvm::Triple::mips64 || machine == llvm::Triple::mips64el) { machine == llvm::Triple::mips64 || machine == llvm::Triple::mips64el) {
switch (m_core) { switch (m_core) {
case ArchSpec::eCore_mips32: case ArchSpec::eCore_mips32:
case ArchSpec::eCore_mips32el: case ArchSpec::eCore_mips32el:
▲ Show 20 Lines • Show All 1,001 Lines • Show Last 20 Lines