This is an archive of the discontinued LLVM Phabricator instance.

[change-namespace] get insertion points of forward declarations correct.
ClosedPublic

Authored by ioeric on Mar 1 2017, 2:10 AM.

Event Timeline

ioeric created this revision.Mar 1 2017, 2:10 AM
hokein added inline comments.Mar 1 2017, 2:21 AM
unittests/change-namespace/ChangeNamespaceTests.cpp
354

I'd create a new test for the fix instead of modifying the current one.

ioeric updated this revision to Diff 90135.Mar 1 2017, 2:26 AM
  • Create a new test case. And slight refactor.
hokein accepted this revision.Mar 1 2017, 2:39 AM

LGTM.

This revision is now accepted and ready to land.Mar 1 2017, 2:39 AM
This revision was automatically updated to reflect the committed changes.