This is an archive of the discontinued LLVM Phabricator instance.

Differential D30481

Updated the XFAIL comment in variant tests.
ClosedPublic

Authored by mpark on Feb 28 2017, 5:12 PM.

Details

Reviewers
EricWF
Commits
rG466f0653a318: Updated the XFAIL comment in variant tests.
rCXX296558: Updated the XFAIL comment in variant tests.
rL296558: Updated the XFAIL comment in variant tests.
Summary

ConstexprTestTypes::NoCtors is an aggregate type (and consequently a literal type) in C++17,
but not in C++14 since it has a base class. This patch updates the comment to accurately describe the reason for the XFAIL.

Diff Detail

Repository
rL LLVM

Event Timeline

mpark created this revision.Feb 28 2017, 5:12 PM
Harbormaster completed remote builds in B4384: Diff 90105.Feb 28 2017, 5:12 PM
mpark edited the summary of this revision. (Show Details)Feb 28 2017, 5:12 PM
EricWF accepted this revision.Feb 28 2017, 5:13 PM
This revision is now accepted and ready to land.Feb 28 2017, 5:13 PM
Closed by commit rL296558: Updated the XFAIL comment in variant tests. (authored by mpark). · Explain WhyFeb 28 2017, 5:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
trunk/
test/
std/
utilities/
variant/
variant.variant/
variant.status/
5 lines
5 lines

Diff 90106

libcxx/trunk/test/std/utilities/variant/variant.variant/variant.status/index.pass.cpp

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// The LLVM Compiler Infrastructure // The LLVM Compiler Infrastructure
// //
// This file is dual licensed under the MIT and the University of Illinois Open // This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details. // Source Licenses. See LICENSE.TXT for details.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++98, c++03, c++11, c++14 // UNSUPPORTED: c++98, c++03, c++11, c++14
// The following compilers don't allow constexpr variables of non-literal type. // The following compilers don't consider a type an aggregate type (and
// consequently not a literal type) if it has a base class at all.
// In C++17, an aggregate type is allowed to have a base class if it's not
// virtual, private, nor protected (e.g. ConstexprTestTypes:::NoCtors).
// XFAIL: gcc-5, gcc-6 // XFAIL: gcc-5, gcc-6
// XFAIL: clang-3.5, clang-3.6, clang-3.7, clang-3.8 // XFAIL: clang-3.5, clang-3.6, clang-3.7, clang-3.8
// XFAIL: apple-clang-6, apple-clang-7, apple-clang-8 // XFAIL: apple-clang-6, apple-clang-7, apple-clang-8
// <variant> // <variant>
// template <class ...Types> class variant; // template <class ...Types> class variant;
Show All 39 Lines

libcxx/trunk/test/std/utilities/variant/variant.variant/variant.status/valueless_by_exception.pass.cpp

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// The LLVM Compiler Infrastructure // The LLVM Compiler Infrastructure
// //
// This file is dual licensed under the MIT and the University of Illinois Open // This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details. // Source Licenses. See LICENSE.TXT for details.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++98, c++03, c++11, c++14 // UNSUPPORTED: c++98, c++03, c++11, c++14
// The following compilers don't allow constexpr variables of non-literal type. // The following compilers don't consider a type an aggregate type (and
// consequently not a literal type) if it has a base class at all.
// In C++17, an aggregate type is allowed to have a base class if it's not
// virtual, private, nor protected (e.g. ConstexprTestTypes:::NoCtors).
// XFAIL: gcc-5, gcc-6 // XFAIL: gcc-5, gcc-6
// XFAIL: clang-3.5, clang-3.6, clang-3.7, clang-3.8 // XFAIL: clang-3.5, clang-3.6, clang-3.7, clang-3.8
// XFAIL: apple-clang-6, apple-clang-7, apple-clang-8 // XFAIL: apple-clang-6, apple-clang-7, apple-clang-8
// <variant> // <variant>
// template <class ...Types> class variant; // template <class ...Types> class variant;
Show All 32 Lines