[mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

[brad]

Summary

Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

[brad]

ping?

[sdardis]

This wasn't trapped by my filters when it was first posted - sorry about that. In future if it's a mips related patch you can add me directly as a reviewer when posting the patch. Changing the subscribers doesn't nag the list or the newly added person. Also, please upload patches with context - http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

From my reading of the GCC sources with OpenBSD's patches and r282184, LGTM.

[brad]

Good to know about the reviewer.

I am not familiar with phabricator and was just trying something with the addition of the subscriber.

I will keep the amount of context in mind for future diffs.

Thanks.

[sdardis]

Do you need me to commit this for you?

[sdardis]

FYI, you should close this revision manually and cite the commit (rL297098). Also please cite the review and all the reviewers when you commit. E.g. the commit message for that should be:

[mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64.

Reviewers: sdardis

Differential Revision: https://reviews.llvm.org/D30465

Doing all this helps with auditing commits and future maintenance. Phab will pick up on commit messages in that form and close the review automatically. The arcanist tool will automate adding the necessary lines to the commit message.

[sdardis]

Closing this, rL297098.

lib/Basic/Targets.cpp

 
   void setN64ABITypes() {
     setN32N64ABITypes();
-    Int64Type = SignedLong;
+    if (getTriple().getOS() == llvm::Triple::OpenBSD) {
+      Int64Type = SignedLongLong;
+    } else {
+      Int64Type = SignedLong;
+    }
     IntMaxType = Int64Type;
     LongWidth = LongAlign = 64;
     PointerWidth = PointerAlign = 64;

test/Preprocessor/init.c

 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-unknown-openbsd6.1-gnueabi < /dev/null | FileCheck -match-full-lines -check-prefix OPENBSD %s
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=i386-unknown-openbsd6.1 < /dev/null | FileCheck -match-full-lines -check-prefix OPENBSD %s
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-unknown-openbsd6.1 < /dev/null | FileCheck -match-full-lines -check-prefix OPENBSD %s
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=mips64-unknown-openbsd6.1 < /dev/null | FileCheck -match-full-lines -check-prefix OPENBSD %s
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=mips64el-unknown-openbsd6.1 < /dev/null | FileCheck -match-full-lines -check-prefix OPENBSD %s
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=sparc64-unknown-openbsd6.1 < /dev/null | FileCheck -match-full-lines -check-prefix OPENBSD %s
 // OPENBSD:#define __ELF__ 1
 // OPENBSD:#define __INT16_TYPE__ short