Page MenuHomePhabricator
Differential D30444

Rename isKnownNotFullPoison to programUndefinedIfPoison; NFC
ClosedPublic
Actions

Authored by sanjoy on Feb 27 2017, 10:55 PM.

Details

Reviewers
broune
majnemer
bjarke.roune
Commits
rG08989c7ecda1: Rename isKnownNotFullPoison to programUndefinedIfPoison; NFC
rL301776: Rename isKnownNotFullPoison to programUndefinedIfPoison; NFC
Summary

programUndefinedIfPoison makes more sense, given what the function
does; and I'm about to add a function with a name similar to
isKnownNotFullPoison (so do the rename to avoid confusion).

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy created this revision.Feb 27 2017, 10:55 PM
Herald added subscribers: mzolotukhin, mcrosier. · View Herald TranscriptFeb 27 2017, 10:55 PM
broune accepted this revision.Feb 27 2017, 11:07 PM

Seems fine, though I think it would have to be programUndefinedIfFullPoison.

This revision is now accepted and ready to land.Feb 27 2017, 11:07 PM
sanjoy added a child revision: D30446: [IndVars] Do not branch on poison.Mar 14 2017, 4:12 PM
Closed by commit rL301776: Rename isKnownNotFullPoison to programUndefinedIfPoison; NFC (authored by sanjoy). · Explain WhyApr 30 2017, 12:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
include/
llvm/
Analysis/
2 lines
lib/
Analysis/
3 lines
2 lines
Transforms/
Scalar/
2 lines
test/
Analysis/
ScalarEvolution/
2 lines

Diff 97240

View Options

llvm/trunk/include/llvm/Analysis/ValueTracking.h

Loading...
View Options

llvm/trunk/lib/Analysis/ScalarEvolution.cpp

Loading...
View Options

llvm/trunk/lib/Analysis/ValueTracking.cpp

Loading...
View Options

llvm/trunk/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp

Loading...
View Options

llvm/trunk/test/Analysis/ScalarEvolution/flags-from-poison.ll

Loading...