Some of the vectors are under sized to avoid heap allocation. In one case the vector was oversized.
Not sure if 64 uint64_ts is maybe too much stack space.
Paths
| Differential D30387
[X86] Fix SmallVector sizes in constant pool shuffle decoding to avoid heap allocation ClosedPublic Authored by craig.topper on Feb 26 2017, 6:28 PM.
Details Summary Some of the vectors are under sized to avoid heap allocation. In one case the vector was oversized. Not sure if 64 uint64_ts is maybe too much stack space.
Diff Detail
Event TimelineComment Actions LGTM - I wonder if there's any useful (i.e. not unnecessarily noisy) that we could get the compiler to report cases where SmallVector has exceeded its 'stack' size? This revision is now accepted and ready to land.Feb 27 2017, 6:38 AM Closed by commit rL296353: [X86] Fix SmallVector sizes in constant pool shuffle decoding to avoid heap… (authored by ctopper). · Explain WhyFeb 27 2017, 8:27 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 89886 llvm/trunk/lib/Target/X86/X86ShuffleDecodeConstantPool.cpp
|