Page MenuHomePhabricator

Map ELF files as writable so we can update the relocations in them

Authored by tberghammer on Feb 22 2017, 5:04 AM.



Map ELF files as writable so we can update the relocations in them

After this change ELF files will be mapped as private writable pages so
we can cheaply update the relocations inside them without have to read
them into memory and any modification we do in the memory will not be
reflected in the on disk files.

Diff Detail

Event Timeline

tberghammer created this revision.Feb 22 2017, 5:04 AM
labath edited edge metadata.

Adding Zachary as he was about to remove this code.

The timing of this patch is a bit unfortunate, as it would complicate the removal of the code in question. If I am not mistaken, llvm's version currently does not support copy-on-write mappings, which is what we are trying to do here. The c-o-w could certainly be added there, and we will probably need to do it in the future, but I am not sure whether this is the right time for it. I don't want to impede Zachary's cleanup effort due to a "feature" that noone has serious commitment of supporting.

clayborg accepted this revision.Feb 22 2017, 11:12 AM
This revision is now accepted and ready to land.Feb 22 2017, 11:12 AM
tberghammer abandoned this revision.Aug 16 2017, 4:43 AM