[ELF] - Make ASSERT() return Dot instead of evaluated value.

[grimar]

Summary

Currently we fail with "unable to move location counter backward" in scripts that
assign ASSERT to Dot.

Previously ASSERT we implemented earlier returned expression value.
Ex:

. = ASSERT(0x100);

would set Dot to 0x100

Documentation does not say anything about this behavior:
"ASSERT(exp, message) Ensure that exp is non-zero. If it is zero, then exit the linker with an error code, and print message."

As far I know form of assert when it is assigned to Dot was used for compatibility with very old GNU ld whick required it.
Some scripts in the wild, including linux kernel scripts use ASSERTs at the end for checks, like:

<many script code here>
/*
 * Build-time check on the image size:
 */
. = ASSERT((_end - _text <= (512 * 1024 * 1024)), "kernel image bigger than KERNEL_IMAGE_SIZE");

Since we error out moving backward now, I thing it is reasonable just to change behavior to return Dot. That way ASSERT will be unable
to move it backward. Anyways since that form was implemented just for compatibility, we probably should not really care what does
it return.

That fixes issue I am observing now when trying to use reproduce for vmlinux,

[ruiu]

LGTM

test/ELF/linkerscript/locationcountererr2.s

7 ↗

(On Diff #89127)

Please make a test as simple as possible. You can replace 0x10 > 0x1 with 1.

lld/trunk/ELF/LinkerScript.cpp

 
 Expr ScriptParser::readAssert() {
   expect("(");
   Expr E = readExpr();
   expect(",");
   StringRef Msg = unquote(next());
   expect(")");
   return [=](uint64_t Dot) {
-    uint64_t V = E(Dot);
-    if (!V)
+    if (!E(Dot))
       error(Msg);
-    return V;
+    return Dot;
   };
 }
 
 // Reads a FILL(expr) command. We handle the FILL command as an
 // alias for =fillexp section attribute, which is different from
 // what GNU linkers do.
 // https://sourceware.org/binutils/docs/ld/Output-Section-Data.html
 uint32_t ScriptParser::readFill() {

lld/trunk/test/ELF/linkerscript/assert.s

 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1.o
 
 # RUN: echo "SECTIONS { ASSERT(1, fail) }" > %t1.script
 # RUN: ld.lld -shared -o %t1 --script %t1.script %t1.o
 # RUN: llvm-readobj %t1 > /dev/null
 
-# RUN: echo "SECTIONS { ASSERT(ASSERT(42, fail) == 42, fail) }" > %t2.script
-# RUN: ld.lld -shared -o %t2 --script %t2.script %t1.o
-# RUN: llvm-readobj %t2 > /dev/null
-
 # RUN: echo "SECTIONS { ASSERT(0, fail) }" > %t3.script
 # RUN: not ld.lld -shared -o %t3 --script %t3.script %t1.o > %t.log 2>&1
 # RUN: FileCheck %s -check-prefix=FAIL < %t.log
 # FAIL: fail
 
 # RUN: echo "SECTIONS { . = ASSERT(0x1000, fail); }" > %t4.script
 # RUN: ld.lld -shared -o %t4 --script %t4.script %t1.o
 # RUN: llvm-readobj %t4 > /dev/null

lld/trunk/test/ELF/linkerscript/locationcountererr2.s

 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
 # RUN: echo "SECTIONS { . = 0x20; . = 0x10; }" > %t.script
 # RUN: not ld.lld %t.o --script %t.script -o %t -shared 2>&1 | FileCheck %s
 # CHECK: unable to move location counter backward
+
+# RUN: echo "SECTIONS { . = 0x20; . = ASSERT(0x1, "foo"); }" > %t2.script
+# RUN: ld.lld %t.o --script %t2.script -o %t -shared