Page MenuHomePhabricator

[sancov] using comdat only when it is enabled
AbandonedPublic

Authored by aizatsky on Feb 8 2017, 2:54 PM.

Details

Reviewers
kcc

Event Timeline

aizatsky created this revision.Feb 8 2017, 2:54 PM
aizatsky updated this revision to Diff 87719.Feb 8 2017, 3:10 PM

split trace-pc-guard test into two.

aizatsky added a reviewer: kcc.Feb 8 2017, 3:10 PM

Kostya, please take a look.

I could suggest to remove all CHECKS but check for ctor from darwin but that wouldn't check the bulk of instrumentation.

It is also possible to extract only module_ctor checks into separate test but I'm not sure how useful it will be.

Actually, hold on a second, I'll replace the triple in darwin file, and that should take care of everything.

aizatsky updated this revision to Diff 87720.Feb 8 2017, 3:19 PM

using target triple as intended.

aizatsky abandoned this revision.Feb 8 2017, 3:19 PM

Will reupload to add llvm-commits correctly