This is an archive of the discontinued LLVM Phabricator instance.

[XRay] [clang] Allow logging the first argument of a function call.
ClosedPublic

Authored by pelikan on Feb 7 2017, 9:46 PM.

Details

Summary

Functions with the "xray_log_args" attribute will tell LLVM to emit a special
XRay sled for compiler-rt to copy any call arguments to your logging handler.

Event Timeline

pelikan created this revision.Feb 7 2017, 9:46 PM
dberris accepted this revision.Feb 9 2017, 12:18 AM

Just a minor comment -- I suspect you're going to wait until the patch to LLVM lands?

lib/Sema/SemaDeclAttr.cpp
4407

What is "It" referring to here? The argument?

This revision is now accepted and ready to land.Feb 9 2017, 12:18 AM
pelikan updated this revision to Diff 90431.Mar 2 2017, 9:40 PM
pelikan marked an inline comment as done.
  • clarify comment and rename variable so it'll all fit.
This revision was automatically updated to reflect the committed changes.