This is an archive of the discontinued LLVM Phabricator instance.

Differential D29533

[libFuzzer] Update tests with environment variables.
ClosedPublic

Authored by mpividori on Feb 3 2017, 10:29 PM.

Details

Reviewers
kcc
zturner
Commits
rG8fcd6d8394c5: [libFuzzer] Update fuzzer-segv to set environment variables.
rL294381: [libFuzzer] Update fuzzer-segv to set environment variables.
Summary

Use env to set environment variables, so it works on Linux and Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

mpividori created this revision.Feb 3 2017, 10:29 PM
kcc edited edge metadata.Feb 6 2017, 11:18 AM

That's too much of a difference. Please figure our how to make env work on windows, or drop this test.

mpividori updated this revision to Diff 87296.Feb 6 2017, 1:43 PM

@kcc you are right. This could be done easily using env, because we have gnu win tools. (This is what we do for asan tests)

kcc accepted this revision.Feb 6 2017, 1:50 PM

LGTM
update the patch description, please

This revision is now accepted and ready to land.Feb 6 2017, 1:50 PM
mpividori retitled this revision from [libFuzzer] Separate tests with environment variables. to [libFuzzer] Update tests with environment variables..Feb 6 2017, 2:50 PM
mpividori edited the summary of this revision. (Show Details)
Closed by commit rL294381: [libFuzzer] Update fuzzer-segv to set environment variables. (authored by mpividori). · Explain WhyFeb 7 2017, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Fuzzer/
test/
2 lines

Diff 87549

llvm/trunk/lib/Fuzzer/test/fuzzer-segv.test

RUN: ASAN_OPTIONS=handle_segv=0 not LLVMFuzzer-NullDerefTest 2>&1 | FileCheck %s --check-prefix=LIBFUZZER_OWN_SEGV_HANDLER RUN: env ASAN_OPTIONS=handle_segv=0 not LLVMFuzzer-NullDerefTest 2>&1 | FileCheck %s --check-prefix=LIBFUZZER_OWN_SEGV_HANDLER
LIBFUZZER_OWN_SEGV_HANDLER: == ERROR: libFuzzer: deadly signal LIBFUZZER_OWN_SEGV_HANDLER: == ERROR: libFuzzer: deadly signal
LIBFUZZER_OWN_SEGV_HANDLER: SUMMARY: libFuzzer: deadly signal LIBFUZZER_OWN_SEGV_HANDLER: SUMMARY: libFuzzer: deadly signal
LIBFUZZER_OWN_SEGV_HANDLER: Test unit written to ./crash- LIBFUZZER_OWN_SEGV_HANDLER: Test unit written to ./crash-