[ELF] - Use SignExtend when reading R_386_PC8, R_386_PC16 addends.

[grimar]

Summary

Previously we did not do that. For example, for R_386_PC8,
0xFF addend was not treated as 0xFFFFFFFF(-1),
but was 0x000000FF.

Recently added checks for R_386_PC8/R_386_PC16 failed because of calculation
overflow as a result.

[grimar]

• Addressed comments, simplified testcase.

[ruiu]

This does the same thing as https://reviews.llvm.org/D29493. Please merge the two patches.

[grimar]

• Merged with D29493 (R_386_PC16 part)
• Addressed review comments.

[grimar]

• Addressed review comments.

[ruiu]

Don't you need to sign-extend not only these two but all operands that have signed values, do you?

lld/trunk/ELF/Target.cpp

 }
 
 int64_t X86TargetInfo::getImplicitAddend(const uint8_t *Buf,
                                          uint32_t Type) const {
   switch (Type) {
   default:
     return 0;
   case R_386_8:
-  case R_386_PC8:
     return *Buf;
+  case R_386_PC8:
+    return SignExtend64<8>(*Buf);
   case R_386_16:
-  case R_386_PC16:
     return read16le(Buf);
+  case R_386_PC16:
+    return SignExtend64<16>(read16le(Buf));
   case R_386_32:
   case R_386_GOT32:
   case R_386_GOT32X:
   case R_386_GOTOFF:
   case R_386_GOTPC:
   case R_386_PC32:
   case R_386_PLT32:
   case R_386_TLS_LE:

lld/trunk/test/ELF/i386-pc8-pc16-addend.s

+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=i386-pc-linux-gnu %s -o %t1.o
+
+# RUN: ld.lld %t1.o -o %t.out
+# RUN: llvm-objdump -s -t %t.out | FileCheck %s
+# CHECK:      Contents of section .text:
+# CHECK-NEXT:  11000 020000 
+## 0x11003 - 0x11000 + addend(-1) = 0x02
+## 0x11003 - 0x11001 + addend(-2) = 0x0000
+# CHECK: SYMBOL TABLE:
+# CHECK: 00011003 .und
+
+.byte  und-.-1
+.short und-.-2
+
+.section .und, "ax"
+und: