[libclang][python] Add test for Index read

[modocache]

Summary

Replace FIXME by adding test for Index read method.

• Add Index read method test.
• Move save_tu method to test util module.
• Place imports on separate lines to conform with style in other test files.

[modocache]

Rebase onto master.

[modocache]

Adding @ddunbar, who added the original FIXME, as a reviewer.

bindings/python/tests/cindex/test_index.py

-from clang.cindex import *
 import os
 
+from clang.cindex import Index
+from clang.cindex import TranslationUnit
+from .util import get_cursor
+from .util import get_tu
+from .util import save_tu
+
 kInputsDir = os.path.join(os.path.dirname(__file__), 'INPUTS')
 
 def test_create():
     index = Index.create()
 
-# FIXME: test Index.read
+def test_read():
+    translation_unit = get_tu('int foo();')
+    path = save_tu(translation_unit)
+
+    index = Index.create()
+    read_unit = index.read(path)
+    assert len(read_unit.diagnostics) == 0
+
+    cursor = get_cursor(read_unit, 'foo')
+    assert cursor is not None
 
 def test_parse():
     index = Index.create()
     assert isinstance(index, Index)
     tu = index.parse(os.path.join(kInputsDir, 'hello.cpp'))
     assert isinstance(tu, TranslationUnit)

bindings/python/tests/cindex/test_translation_unit.py

 import gc
 import os
-import tempfile
 
 from clang.cindex import CursorKind
 from clang.cindex import Cursor
 from clang.cindex import File
 from clang.cindex import Index
 from clang.cindex import SourceLocation
 from clang.cindex import SourceRange
 from clang.cindex import TranslationUnitSaveError
 from clang.cindex import TranslationUnitLoadError
 from clang.cindex import TranslationUnit
 from .util import get_cursor
 from .util import get_tu
+from .util import save_tu
 
 kInputsDir = os.path.join(os.path.dirname(__file__), 'INPUTS')
 
 def test_spelling():
     path = os.path.join(kInputsDir, 'hello.cpp')
     tu = TranslationUnit.from_source(path)
     assert tu.spelling == path
 
def test_includes():
     h2 = os.path.join(kInputsDir, "header2.h")
     h3 = os.path.join(kInputsDir, "header3.h")
     inc = [(src, h1), (h1, h3), (src, h2), (h2, h3)]
 
     tu = TranslationUnit.from_source(src)
     for i in zip(inc, tu.get_includes()):
         assert eq(i[0], i[1])
 
-def save_tu(tu):
-    """Convenience API to save a TranslationUnit to a file.
-
-    Returns the filename it was saved to.
-    """
-    _, path = tempfile.mkstemp()
-    tu.save(path)
-
-    return path
-
 def test_save():
     """Ensure TranslationUnit.save() works."""
 
     tu = get_tu('int foo();')
 
     path = save_tu(tu)
     assert os.path.exists(path)
     assert os.path.getsize(path) > 0

bindings/python/tests/cindex/util.py

 # This file provides common utility functions for the test suite.
 
+import tempfile
+
 from clang.cindex import Cursor
 from clang.cindex import TranslationUnit
 
 def get_tu(source, lang='c', all_warnings=False, flags=[]):
     """Obtain a translation unit from source and language.
 
     By default, the translation unit is created from source file "t.<ext>"
     where <ext> is the default file extension for the specified language. By
elif lang != 'c':
         raise Exception('Unknown language: %s' % lang)
 
     if all_warnings:
         args += ['-Wall', '-Wextra']
 
     return TranslationUnit.from_source(name, args, unsaved_files=[(name,
                                        source)])
 
+def save_tu(tu):
+    """Convenience API to save a TranslationUnit to a file.
+
+    Returns the filename it was saved to.
+    """
+    _, path = tempfile.mkstemp()
+    tu.save(path)
+
+    return path
+
 def get_cursor(source, spelling):
     """Obtain a cursor from a source object.
 
     This provides a convenient search mechanism to find a cursor with specific
     spelling within a source. The first argument can be either a
     TranslationUnit or Cursor instance.
 
     If the cursor is not found, None is returned.
for cursor in children:
             return cursor
 
         # Recurse into children.
         result = get_cursor(cursor, spelling)
         if result is not None:
             return result
 
     return None
- 
 def get_cursors(source, spelling):
     """Obtain all cursors from a source object with a specific spelling.
 
     This provides a convenient search mechanism to find all cursors with specific
     spelling within a source. The first argument can be either a
     TranslationUnit or Cursor instance.
 
     If no cursors are found, an empty list is returned.
for cursor in children:
         if cursor.spelling == spelling:
             cursors.append(cursor)
 
         # Recurse into children.
         cursors.extend(get_cursors(cursor, spelling))
 
     return cursors
 
-    
-    
-
 __all__ = [
     'get_cursor',
     'get_cursors',
     'get_tu',
 ]