[libcxx] [test] Fix Clang -Wunused-local-typedef, part 3/3.

[STL_MSFT]

Summary

[libcxx] [test] Fix Clang -Wunused-local-typedef, part 3/3.

test/std/strings/string.classes/typedefs.pass.cpp
Actually test what basic_string's typedefs stand for.

test/std/utilities/meta/meta.trans/meta.trans.other/result_of11.pass.cpp
NotDerived and ND were completely unused.

test/std/utilities/utility/pairs/pairs.pair/default.pass.cpp
P2 was mistakenly not being used. Yes, that's
right: -Wunused-local-typedef CAUGHT A MISTAKE! AMAZING!

[EricWF]

test/std/utilities/utility/pairs/pairs.pair/default.pass.cpp

52

Oh wow! these changes actually found a bug!

test/std/strings/string.classes/typedefs.pass.cpp

 
 // basic_string typedef names
 // typedef basic_string<char> string;
 // typedef basic_string<char16_t> u16string;
 // typedef basic_string<char32_t> u32string;
 // typedef basic_string<wchar_t> wstring;
 
 #include <string>
+#include <type_traits>
 
 int main()
 {
-    typedef std::string test1;
-    typedef std::wstring test2;
+    static_assert((std::is_same<std::string, std::basic_string<char> >::value), "");
+    static_assert((std::is_same<std::wstring, std::basic_string<wchar_t> >::value), "");
 #ifndef _LIBCPP_HAS_NO_UNICODE_CHARS
-    typedef std::u16string test3;
-    typedef std::u32string test4;
+    static_assert((std::is_same<std::u16string, std::basic_string<char16_t> >::value), "");
+    static_assert((std::is_same<std::u32string, std::basic_string<char32_t> >::value), "");
 #endif  // _LIBCPP_HAS_NO_UNICODE_CHARS
 }

test/std/utilities/meta/meta.trans/meta.trans.other/result_of11.pass.cpp

 struct wat
 {
     wat& operator*() { return *this; }
     void foo();
 };
 
 struct F {};
 struct FD : public F {};
-struct NotDerived {};
 
 template <class T, class U>
 void test_result_of_imp()
 {
     static_assert((std::is_same<typename std::result_of<T>::type, U>::value), "");
 #if TEST_STD_VER > 11
     static_assert((std::is_same<std::result_of_t<T>, U>::value), "");
 #endif
 #if TEST_STD_VER > 14
     static_assert(std::is_callable<T>::value, "");
     static_assert(std::is_callable<T, U>::value, "");
 #endif
 }
 
 int main()
 {
-    typedef NotDerived ND;
     {
     typedef char F::*PMD;
     test_result_of_imp<PMD(F                &), char                &>();
     test_result_of_imp<PMD(F const          &), char const          &>();
     test_result_of_imp<PMD(F volatile       &), char volatile       &>();
     test_result_of_imp<PMD(F const volatile &), char const volatile &>();
 
     test_result_of_imp<PMD(F                &&), char                &&>();

test/std/utilities/utility/pairs/pairs.pair/default.pass.cpp

#if TEST_STD_VER >= 11
         static_assert(p.first == 0.0f, "");
         static_assert(p.second == nullptr, "");
     }
     {
         using NoDefault = ImplicitTypes::NoDefault;
         using P = std::pair<int, NoDefault>;
         static_assert(!std::is_default_constructible<P>::value, "");
         using P2 = std::pair<NoDefault, int>;
-        static_assert(!std::is_default_constructible<P>::value, "");
+        static_assert(!std::is_default_constructible<P2>::value, "");
     }
 #endif
 }