This is an archive of the discontinued LLVM Phabricator instance.

Differential D29066

Forward -bitcode_process_mode to ld64 in marker-only mode
ClosedPublic

Authored by mehdi_amini on Jan 23 2017, 6:41 PM.

Details

Reviewers
steven_wu
Commits
rG04e1a0a171cc: Forward -bitcode_process_mode to ld64 in marker-only mode
rC292961: Forward -bitcode_process_mode to ld64 in marker-only mode
rL292961: Forward -bitcode_process_mode to ld64 in marker-only mode

Diff Detail

Event Timeline

mehdi_amini created this revision.Jan 23 2017, 6:41 PM
Harbormaster completed remote builds in B3225: Diff 85512.Jan 23 2017, 6:41 PM
mehdi_amini added a parent revision: D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly()..Jan 23 2017, 6:42 PM
mehdi_amini updated this revision to Diff 85530.Jan 23 2017, 9:43 PM

Add a test

steven_wu accepted this revision.Jan 23 2017, 9:58 PM

LGTM

This revision is now accepted and ready to land.Jan 23 2017, 9:58 PM
Closed by commit rL292961: Forward -bitcode_process_mode to ld64 in marker-only mode (authored by mehdi_amini). · Explain WhyJan 24 2017, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Driver/
8 lines

Diff 85512

clang/lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,429 Lines • ▼ Show 20 Lines if (A->getOption().matches(options::OPT_fpie) ||
CmdArgs.push_back("-pie"); CmdArgs.push_back("-pie");
else else
CmdArgs.push_back("-no_pie"); CmdArgs.push_back("-no_pie");
} }
// for embed-bitcode, use -bitcode_bundle in linker command // for embed-bitcode, use -bitcode_bundle in linker command
if (C.getDriver().embedBitcodeEnabled()) { if (C.getDriver().embedBitcodeEnabled()) {
// Check if the toolchain supports bitcode build flow. // Check if the toolchain supports bitcode build flow.
if (MachOTC.SupportsEmbeddedBitcode()) if (MachOTC.SupportsEmbeddedBitcode()) {
CmdArgs.push_back("-bitcode_bundle"); CmdArgs.push_back("-bitcode_bundle");
else if (C.getDriver().embedBitcodeMarkerOnly() && Version[0] >= 278) {
CmdArgs.push_back("-bitcode_process_mode");
CmdArgs.push_back("marker");
}
} else
D.Diag(diag::err_drv_bitcode_unsupported_on_toolchain); D.Diag(diag::err_drv_bitcode_unsupported_on_toolchain);
} }
Args.AddLastArg(CmdArgs, options::OPT_prebind); Args.AddLastArg(CmdArgs, options::OPT_prebind);
Args.AddLastArg(CmdArgs, options::OPT_noprebind); Args.AddLastArg(CmdArgs, options::OPT_noprebind);
Args.AddLastArg(CmdArgs, options::OPT_nofixprebinding); Args.AddLastArg(CmdArgs, options::OPT_nofixprebinding);
Args.AddLastArg(CmdArgs, options::OPT_prebind__all__twolevel__modules); Args.AddLastArg(CmdArgs, options::OPT_prebind__all__twolevel__modules);
Args.AddLastArg(CmdArgs, options::OPT_read__only__relocs); Args.AddLastArg(CmdArgs, options::OPT_read__only__relocs);
▲ Show 20 Lines • Show All 3,787 Lines • Show Last 20 Lines