Page MenuHomePhabricator

[mips] Add support for static model on N64
ClosedPublic

Authored by sdardis on Jan 23 2017, 7:45 AM.

Details

Summary

The patch teaches the Clang driver how to handle the N64 static
relocation model properly. It enforces the correct target feature
(+noabicalls) when -fno-pic is used. This is required as non-pic
N64 code as the abi extension to call PIC code (CPIC) is unsupported.

Make PIC the default for mips64 and mips64el, this affects both N32
& N64 ABIs, to better match GCC.

As part of this effort, clean up the assembler invocation command
builder, so the correct flags are used.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis created this revision.Jan 23 2017, 7:45 AM
seanbruno accepted this revision.Jan 24 2017, 6:29 AM

From a "does this work" perspective, FreeBSD compiles are better now with this in place.

This revision is now accepted and ready to land.Jan 24 2017, 6:29 AM

@slthakur can you take a look at this too?

Thanks,
Simon

This revision was automatically updated to reflect the committed changes.