This is an archive of the discontinued LLVM Phabricator instance.

Make VerifyDonInfo and VerifyLoopInfo global variables
ClosedPublic

Authored by sepavloff on Jan 23 2017, 7:38 AM.

Details

Summary

Verifications of dominator tree and loop info are expensive operations
so they are disabled by default. They can be enabled by command line
options -verify-dom-info and -verify-loop-info. These options however
enable checks only in files Dominators.cpp and LoopInfo.cpp. If some
transformation changes dominaror tree and/or loop info, it would be
convenient to place similar checks to the files implementing the
transformation.

This change makes corresponding flags global, so they can be used in
any file to optionally turn verification on.

Event Timeline

sepavloff created this revision.Jan 23 2017, 7:38 AM
mzolotukhin accepted this revision.Jan 23 2017, 1:51 PM

Looks good to me!

Michael

This revision is now accepted and ready to land.Jan 23 2017, 1:51 PM
sepavloff closed this revision.Jan 25 2017, 12:13 AM

Committed in r292889.