This is an archive of the discontinued LLVM Phabricator instance.

Fix typos and update "GDB To LLDB Command Map" to be a bit more clear
ClosedPublic

Authored by saagarjha on Jan 15 2017, 6:45 PM.

Details

Summary

I've gone through the GDB To LLDB Command Map and tried to improve it:

  • Fix obvious typos (e.g. <cope><code>, "object C" to "Objective C")
  • Wrap code and program names in <code> tags
  • Convert names (e.g. "Mac OS X" → "macOS", "ObjC" → "Objective C"
  • Reword a couple parts where (IMHO) the phrasing could be a bit better

Diff Detail

Event Timeline

saagarjha updated this revision to Diff 84516.Jan 15 2017, 6:45 PM
saagarjha retitled this revision from to Fix typos and update "GDB To LLDB Command Map" to be a bit more clear.
saagarjha updated this object.
saagarjha added a reviewer: lldb-commits.
saagarjha set the repository for this revision to rL LLVM.
saagarjha added a project: Restricted Project.
saagarjha added a subscriber: lldb-commits.
jingham accepted this revision.Jan 17 2017, 8:43 AM
jingham added a subscriber: jingham.

This looks fine to me. Thanks for cleaning this up!

This revision is now accepted and ready to land.Jan 17 2017, 8:43 AM
saagarjha added a comment.EditedJan 31 2017, 7:54 PM

@jingham Sorry if this is a stupid question, but it's been a while and it doesn't appear that anything has happened with this patch; what should I do with it? Should I be sending this patch to lldb-commits to be merged? Or will this all happen automatically? (Please bear with me–I've never committed to LLVM before, and I'm still trying to figure out how reviews work.)

keith added a subscriber: keith.Jan 15 2023, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2023, 10:35 AM