[libc++] Overallocation of am_pm array in locale.cpp

[dcdillon]

Summary

Changed array size from 24 to 2 in init_am_pm() and init_wam_pm()

[mclow.lists]

This looks fine to me.
All the other places that use this (or related functionality) have a rank of 2.

Interestingly enough, this has been there since "the beginning of time" (the initial import of libc++ into the LLVM subversion repo)

[mclow.lists]

Committed as r322295

src/locale.cpp

__time_get_c_storage<wchar_t>::__months() const
     static const wstring* months = init_wmonths();
     return months;
 }
 
 static
 string*
 init_am_pm()
 {
-    static string am_pm[24];
+    static string am_pm[2];
     am_pm[0]  = "AM";
     am_pm[1]  = "PM";
     return am_pm;
 }
 
 static
 wstring*
 init_wam_pm()
 {
-    static wstring am_pm[24];
+    static wstring am_pm[2];
     am_pm[0]  = L"AM";
     am_pm[1]  = L"PM";
     return am_pm;
 }
 
 template <>
 const string*
 __time_get_c_storage<char>::__am_pm() const