[IR] Don't call assertModuleIsMaterialized in release builds

[craig.topper]

Summary

To fix a release vs debug build linking error, r259695 made the body of assertModuleIsMaterialized empty if Value.cpp gets compiled in a release build. This way any code compiled as a debug build can still link against a release version of the function.

This patch takes this a step farther and removes all calls to it from Value.h in any code that includes it in a relase build.

This shrinks the opt binary on my macbook build by 17240 bytes.

[craig.topper]

Make the patch less intrusive by renaming the existing method to Impl and putting a inline method around a call to contain the #ifndefs.

include/llvm/IR/Value.h

public:
   // The methods that start with materialized_ check the uses that are
   // currently known given which functions are materialized. Be very careful
   // when using them since you might not get all uses.
   // The methods that don't start with materialized_ assert that modules is
   // fully materialized.
   void assertModuleIsMaterialized() const;
 
   bool use_empty() const {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return UseList == nullptr;
   }
 
   typedef use_iterator_impl<Use> use_iterator;
   typedef use_iterator_impl<const Use> const_use_iterator;
   use_iterator materialized_use_begin() { return use_iterator(UseList); }
   const_use_iterator materialized_use_begin() const {
     return const_use_iterator(UseList);
   }
   use_iterator use_begin() {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_use_begin();
   }
   const_use_iterator use_begin() const {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_use_begin();
   }
   use_iterator use_end() { return use_iterator(); }
   const_use_iterator use_end() const { return const_use_iterator(); }
   iterator_range<use_iterator> materialized_uses() {
     return make_range(materialized_use_begin(), use_end());
   }
   iterator_range<const_use_iterator> materialized_uses() const {
     return make_range(materialized_use_begin(), use_end());
   }
   iterator_range<use_iterator> uses() {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_uses();
   }
   iterator_range<const_use_iterator> uses() const {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_uses();
   }
 
   bool user_empty() const {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return UseList == nullptr;
   }
 
   typedef user_iterator_impl<User> user_iterator;
   typedef user_iterator_impl<const User> const_user_iterator;
   user_iterator materialized_user_begin() { return user_iterator(UseList); }
   const_user_iterator materialized_user_begin() const {
     return const_user_iterator(UseList);
   }
   user_iterator user_begin() {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_user_begin();
   }
   const_user_iterator user_begin() const {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_user_begin();
   }
   user_iterator user_end() { return user_iterator(); }
   const_user_iterator user_end() const { return const_user_iterator(); }
   User *user_back() {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return *materialized_user_begin();
   }
   const User *user_back() const {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return *materialized_user_begin();
   }
   iterator_range<user_iterator> materialized_users() {
     return make_range(materialized_user_begin(), user_end());
   }
   iterator_range<const_user_iterator> materialized_users() const {
     return make_range(materialized_user_begin(), user_end());
   }
   iterator_range<user_iterator> users() {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_users();
   }
   iterator_range<const_user_iterator> users() const {
+#ifndef NDEBUG
     assertModuleIsMaterialized();
+#endif
     return materialized_users();
   }
 
   /// \brief Return true if there is exactly one user of this value.
   ///
   /// This is specialized because it is a common request and does not require
   /// traversing the whole use list.
   bool hasOneUse() const {