This is an archive of the discontinued LLVM Phabricator instance.

Force the installation of lldb-server and lldb-argdumper
AbandonedPublic

Authored by sylvestre.ledru on Dec 29 2016, 4:12 AM.

Reviewers

Summary

For some reasons, the usage of add_lldb_tool instead of add_lldb_executable causes these two binaries not be installed.
This patch fixes the issue

sylvestre.ledru retitled this revision from to Force the installation of lldb-server and lldb-argdumper.

sylvestre.ledru updated this object.

sylvestre.ledru added a subscriber: Restricted Project.

Wouldn't it be better to either fix add_lldb_tool or switch to add_lldb_executable?

Probably, I did it the easy way

I don't know what ARG_GENERATE_INSTALL in cmake/modules/AddLLDB.cmake is for

I think I fixed this in rL290934.

Thanks!

Path

Size

	llvm-toolchain-snapshot-4.0~svn290518/	lldb/	tools/
	llvm-toolchain-snapshot-4.0~svn290518.orig/	lldb/	tools/

argdumper/

2 lines

lldb-server/

4 lines

Context not available.
	endif()	endif()
	llvm_config(lldb-argdumper ${LLVM_LINK_COMPONENTS})	llvm_config(lldb-argdumper ${LLVM_LINK_COMPONENTS})

		install(TARGETS lldb-argdumper
		RUNTIME DESTINATION bin)
Context not available.

Context not available.
	target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})	target_link_libraries(lldb-server ${LLDB_SYSTEM_LIBS})

	set_target_properties(lldb-server PROPERTIES VERSION ${LLDB_VERSION})	set_target_properties(lldb-server PROPERTIES VERSION ${LLDB_VERSION})

		install(TARGETS lldb-server
		RUNTIME DESTINATION bin)

Context not available.