Page MenuHomePhabricator

InstCombine: Add fma with constant transforms
ClosedPublic

Authored by arsenm on Dec 18 2016, 3:45 PM.

Details

Reviewers
majnemer
Summary

DAGCombine already does these.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 81899.Dec 18 2016, 3:45 PM
arsenm retitled this revision from to InstCombine: Add fma with constant transforms.
arsenm updated this object.
arsenm added a subscriber: llvm-commits.
majnemer added inline comments.
lib/Transforms/InstCombine/InstCombineCalls.cpp
1564

I'd just use isa here.

arsenm updated this revision to Diff 81905.Dec 18 2016, 5:53 PM

Use isa

majnemer added inline comments.Dec 18 2016, 6:48 PM
lib/Transforms/InstCombine/InstCombineCalls.cpp
1564

I think you could also use isa for Src0.

majnemer accepted this revision.Jan 2 2017, 2:24 PM
majnemer added a reviewer: majnemer.

LGTM

This revision is now accepted and ready to land.Jan 2 2017, 2:24 PM
arsenm closed this revision.Jan 2 2017, 8:44 PM

r290860