Page MenuHomePhabricator

ilist_iterator: Allow conversion between reverse and forward iterators

Authored by MatzeB on Dec 16 2016, 6:39 PM.



Diff Detail


Event Timeline

MatzeB updated this revision to Diff 81832.Dec 16 2016, 6:39 PM
MatzeB retitled this revision from to ilist_iterator: Allow conversion between reverse and forward iterators.
MatzeB updated this object.
MatzeB added a reviewer: dexonsmith.
MatzeB set the repository for this revision to rL LLVM.
MatzeB added a subscriber: llvm-commits.
MatzeB abandoned this revision.Jan 25 2017, 3:32 PM

I wasn't aware of the subtle shift-by-1 semantics when converting to std::reverse_iterator (must have missed the getReverse() comment). If we go with that semantics I would need extra std::next/std::prev calls in my code anyway which doesn't make it much simpler compared to MyIterator->getReverseIterator(). Going for semantics different from STL is not a good idea IMO.