This is an archive of the discontinued LLVM Phabricator instance.

[sancov] skip dead files from computations
ClosedPublic

Authored by aizatsky on Dec 16 2016, 2:39 PM.

Event Timeline

aizatsky updated this revision to Diff 81798.Dec 16 2016, 2:39 PM
aizatsky updated this revision to Diff 81799.
aizatsky retitled this revision from to [sancov] skip dead files from computations.
aizatsky updated this object.

format

aizatsky updated this object.Dec 16 2016, 2:42 PM
aizatsky added a reviewer: vitalybuka.
vitalybuka accepted this revision.Dec 16 2016, 3:22 PM
vitalybuka edited edge metadata.
vitalybuka added inline comments.
test/tools/sancov/symbolize.test
7

more convenient would be to have just one file for this tests and use
prefixies, e.g. :

RUN: sancov -symbolize -skip-dead-files=1 -strip_path_prefix="llvm/" %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
RUN: sancov -symbolize -skip-dead-files=0 -strip_path_prefix="llvm/" %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s --check-prefixes=CHECK,CHECK-KEEPDEAD

and replace removed lines with:
CHECK-KEEPDEAD-NEXT: ...

This revision is now accepted and ready to land.Dec 16 2016, 3:22 PM

LGTM either way

I actually prefer to have separate lit tests. When you have multiple tests in a single file and it fails it is sometimes very hard to determine the failure cause.

This revision was automatically updated to reflect the committed changes.