This is an archive of the discontinued LLVM Phabricator instance.

Fixed '!NodePtr->isKnownSentinel()' assert caused by dereferencing end iterator when trying to const cast the iterator.
ClosedPublic

Authored by martin.sherburn on Dec 16 2016, 4:35 AM.

Details

Reviewers
rivanvx
tstellarAMD
nhaehnle
Group Reviewers
Restricted Project
Summary

Fixed '!NodePtr->isKnownSentinel()' assert caused by dereferencing end iterator when trying to const cast the iterator.

Fixes bug in https://llvm.org/bugs/show_bug.cgi?id=30514

See https://reviews.llvm.org/rL279314 for more detail

Diff Detail

Repository
rL LLVM

Event Timeline

martin.sherburn retitled this revision from to Fixed '!NodePtr->isKnownSentinel()' assert caused by dereferencing end iterator when trying to const cast the iterator..
martin.sherburn updated this object.
martin.sherburn added a reviewer: Restricted Project.
martin.sherburn set the repository for this revision to rL LLVM.
martin.sherburn added a project: Restricted Project.
martin.sherburn added a subscriber: Restricted Project.
nhaehnle accepted this revision.Dec 16 2016, 5:01 AM
nhaehnle added a reviewer: nhaehnle.

LGTM

This revision is now accepted and ready to land.Dec 16 2016, 5:01 AM
rivanvx accepted this revision.Dec 16 2016, 8:34 AM
rivanvx added a reviewer: rivanvx.
rivanvx added a subscriber: rivanvx.

LGTM as well

Sorry if this seems obvious but how do I get this committed to source control? This is my first patch so I don't have commit access. I use git mostly so if there is any way to submit a pull request or anything that's great but I'm happy to follow whatever is the usual approach.

You just wait until a maintainer picks it up.

arsenm closed this revision.Dec 22 2016, 8:17 AM

r290347