Page MenuHomePhabricator

[XRay][compiler-rt][NFC] Deduplicate code in x86-64 trampolines.
ClosedPublic

Authored by pelikan on Dec 15 2016, 12:49 AM.

Details

Summary

The layout of all registers saved on stack shouldn't deviate and will be reused in future trampolines as well.

While there, fix whitespace and clarify comments.

Diff Detail

Repository
rL LLVM

Event Timeline

pelikan updated this revision to Diff 81541.Dec 15 2016, 12:49 AM
pelikan retitled this revision from to [XRay][compiler-rt][NFC] Deduplicate code in x86-64 trampolines..
pelikan updated this object.
pelikan added a reviewer: dberris.
pelikan added a subscriber: llvm-commits.
dberris requested changes to this revision.Dec 15 2016, 12:54 AM
dberris edited edge metadata.
dberris added inline comments.
lib/xray/xray_trampoline_x86_64.S
16 ↗(On Diff #81541)

Consider naming this SAVE_REGISTERS to make it a bit more natural to read.

35 ↗(On Diff #81541)

Same idea here, as RESTORE_REGISTERS.

This revision now requires changes to proceed.Dec 15 2016, 12:54 AM
pelikan updated this revision to Diff 81543.Dec 15 2016, 1:04 AM
pelikan edited edge metadata.
  • fix naming
pelikan marked 2 inline comments as done.Dec 15 2016, 1:05 AM

Macro names fixed.

dberris accepted this revision.Dec 15 2016, 1:10 AM
dberris edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2016, 1:10 AM
This revision was automatically updated to reflect the committed changes.