This is an archive of the discontinued LLVM Phabricator instance.

[XRay][compiler-rt] Use explicit comparisons in unit tests.
ClosedPublic

Authored by dberris on Dec 6 2016, 5:18 PM.

Details

Summary

This should improve the error messages generated providing a bit more
information when the failures are printed out. One example of a
contrived error looks like:

Expected: (Buffers.getBuffer(Buf)) != (std::error_code()), actual:
system:0 vs system:0

Because we're using error codes, the default printing gets us more
useful information in case of failure.

This is a follow-up on D26232.

Diff Detail

Repository
rL LLVM

Event Timeline

dberris updated this revision to Diff 80515.Dec 6 2016, 5:18 PM
dberris retitled this revision from to [XRay][compiler-rt] Use explicit comparisons in unit tests..
dberris updated this object.
dberris added a reviewer: rSerge.
dberris added a subscriber: llvm-commits.
rSerge accepted this revision.Dec 12 2016, 8:41 AM
rSerge edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2016, 8:41 AM
This revision was automatically updated to reflect the committed changes.