This is an archive of the discontinued LLVM Phabricator instance.

Add missing parens in assert.
ClosedPublic

Authored by sammccall on Dec 6 2016, 2:21 AM.

Reviewers: None
Commits: rG03435f57aa11: Add missing parens in assert.
rL288792: Add missing parens in assert.

Summary

Add missing parens in assert, which warn in GCC.

Build Status

Buildable 1885
Build 1885: arc lint + arc unit

sammccall retitled this revision from to Add missing parens in assert..

sammccall updated this object.

sammccall added a subscriber: llvm-commits.

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

CodeGen/

GlobalISel/

2 lines

	Show First 20 Lines • Show All 163 Lines • ▼ Show 20 Lines
	MachineInstrBuilder MachineIRBuilder::buildCopy(unsigned Res, unsigned Op) {			MachineInstrBuilder MachineIRBuilder::buildCopy(unsigned Res, unsigned Op) {
	return buildInstr(TargetOpcode::COPY).addDef(Res).addUse(Op);			return buildInstr(TargetOpcode::COPY).addDef(Res).addUse(Op);
	}			}

	MachineInstrBuilder MachineIRBuilder::buildConstant(unsigned Res,			MachineInstrBuilder MachineIRBuilder::buildConstant(unsigned Res,
	const ConstantInt &Val) {			const ConstantInt &Val) {
	LLT Ty = MRI->getType(Res);			LLT Ty = MRI->getType(Res);

	assert(Ty.isScalar() \|\| Ty.isPointer() && "invalid operand type");			assert((Ty.isScalar() \|\| Ty.isPointer()) && "invalid operand type");

	const ConstantInt *NewVal = &Val;			const ConstantInt *NewVal = &Val;
	if (Ty.getSizeInBits() != Val.getBitWidth())			if (Ty.getSizeInBits() != Val.getBitWidth())
	NewVal = ConstantInt::get(MF->getFunction()->getContext(),			NewVal = ConstantInt::get(MF->getFunction()->getContext(),
	Val.getValue().sextOrTrunc(Ty.getSizeInBits()));			Val.getValue().sextOrTrunc(Ty.getSizeInBits()));

	return buildInstr(TargetOpcode::G_CONSTANT).addDef(Res).addCImm(NewVal);			return buildInstr(TargetOpcode::G_CONSTANT).addDef(Res).addCImm(NewVal);
	}			}
	▲ Show 20 Lines • Show All 255 Lines • Show Last 20 Lines