This is an archive of the discontinued LLVM Phabricator instance.

Differential D27328

[CUDA] Fix faulty test from rL288448
ClosedPublic

Authored by jhen on Dec 1 2016, 6:05 PM.

Details

Reviewers
jlebar
Commits
rG13bba6966f9f: [CUDA] Fix faulty test from rL288448
rC288453: [CUDA] Fix faulty test from rL288448
Summary

The test introduced by rL288448 is currently failing because
unimportant but unexpected errors appear as output from a test compile
line. This patch looks for a more specific error message, in order to avoid false positives.

Diff Detail

Event Timeline

jhen updated this revision to Diff 80009.Dec 1 2016, 6:05 PM
jhen retitled this revision from to Remove faulty test from rL288448.
jhen updated this object.
jhen added a reviewer: jlebar.
jhen added a subscriber: cfe-commits.
jhen updated this revision to Diff 80012.Dec 1 2016, 6:09 PM
  • Switch to more specific error
jlebar accepted this revision.Dec 1 2016, 6:09 PM
jlebar edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2016, 6:09 PM
jhen retitled this revision from Remove faulty test from rL288448 to [CUDA] Fix faulty test from rL288448.Dec 1 2016, 6:10 PM
jhen updated this object.
jhen edited edge metadata.
jhen closed this revision.Dec 2 2016, 9:49 AM

Revision Contents

PathSize
test/
Driver/
2 lines

Diff 80012

test/Driver/cuda-no-sanitizers.cu

// Check that -fsanitize=foo doesn't get passed down to device-side // Check that -fsanitize=foo doesn't get passed down to device-side
// compilation. // compilation.
// //
// REQUIRES: clang-driver // REQUIRES: clang-driver
// //
// RUN: %clang -### -target x86_64-linux-gnu -c --cuda-gpu-arch=sm_20 -fsanitize=address %s 2>&1 | \ // RUN: %clang -### -target x86_64-linux-gnu -c --cuda-gpu-arch=sm_20 -fsanitize=address %s 2>&1 | \
// RUN: FileCheck %s // RUN: FileCheck %s
// CHECK-NOT: error: // CHECK-NOT: error: unsupported option '-fsanitize=address'
// CHECK-DAG: "-fcuda-is-device" // CHECK-DAG: "-fcuda-is-device"
// CHECK-NOT: "-fsanitize=address" // CHECK-NOT: "-fsanitize=address"
// CHECK-DAG: "-triple" "x86_64--linux-gnu" // CHECK-DAG: "-triple" "x86_64--linux-gnu"
// CHECK: "-fsanitize=address" // CHECK: "-fsanitize=address"