This is an archive of the discontinued LLVM Phabricator instance.

[lanai] Custom lowering of SHL_PARTS
ClosedPublic

Authored by jpienaar on Nov 29 2016, 3:21 PM.

Details

Summary

Implement custom lowering of SHL_PARTS to enable lowering of left shift with larger than 32-bit shifts.

Event Timeline

jpienaar updated this revision to Diff 79656.Nov 29 2016, 3:21 PM
jpienaar retitled this revision from to [lanai] Custom lowering of SHL_PARTS.
jpienaar updated this object.
jpienaar added reviewers: eliben, majnemer.
jpienaar added a subscriber: llvm-commits.
majnemer added inline comments.Nov 29 2016, 4:47 PM
lib/Target/Lanai/LanaiISelLowering.cpp
1248–1253

It'd be nice if there was more of a correspondence between this pseudo code and the variable names below.

jpienaar updated this revision to Diff 79739.Nov 30 2016, 7:49 AM

Updated the pseudo code variable names to correspond better with actual variable names used.

jpienaar marked an inline comment as done.Nov 30 2016, 7:51 AM
majnemer accepted this revision.Dec 2 2016, 1:17 PM
majnemer edited edge metadata.

LGTM with issues addressed.

test/CodeGen/Lanai/lshift64.ll
6–8

Please check the sequence emitted.

This revision is now accepted and ready to land.Dec 2 2016, 1:17 PM
jpienaar updated this revision to Diff 80131.Dec 2 2016, 2:09 PM
jpienaar edited edge metadata.

Expand test to test lowering of ashldi.

jpienaar marked an inline comment as done.Dec 2 2016, 2:11 PM
jpienaar closed this revision.Dec 2 2016, 2:11 PM