Page MenuHomePhabricator

Remove an x86-ism from RegisterInfoInterface
ClosedPublic

Authored by labath on Nov 29 2016, 12:07 PM.

Details

Summary

While adding FPR support to x86 elf core files (D26300), we ended up adding a
very x86-specific function to the general RegisterInfoInterface class, which I
didn't catch in review. This removes that function. The only reason we needed
it was to find the offset of the FXSAVE area. This is the same as the offset of
the first register within that area, so we might as well use that.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 79618.Nov 29 2016, 12:07 PM
labath retitled this revision from to Remove an x86-ism from RegisterInfoInterface.
labath updated this object.
labath added reviewers: clayborg, dvlahovski.
labath added a subscriber: lldb-commits.
clayborg accepted this revision.Nov 29 2016, 2:45 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 2:45 PM
dvlahovski accepted this revision.Nov 29 2016, 2:52 PM
dvlahovski edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.