Page MenuHomePhabricator

Expensive checks: support promoted floats.

Authored by ayartsev on Nov 24 2016, 12:25 PM.



Hi all!
Attached patch eliminates a number of test failures in LLVM built with expensive checks turned on (-DLLVM_ENABLE_EXPENSIVE_CHECKS:BOOL=True).
DAGTypeLegalizer::PerformExpensiveChecks() is not currently familiar with promoted floats supported at r235215. This causes a number of tests to fail with "Processed value not in any map!" message. The patch solves the issue.
Please review!

Diff Detail

Event Timeline

ayartsev updated this revision to Diff 79252.Nov 24 2016, 12:25 PM
ayartsev retitled this revision from to Expensive checks: support promoted floats..
ayartsev updated this object.
ayartsev added a subscriber: llvm-commits.

I would propose to take some existing test, which fails with expensive checks enabled, and add -enable-legalize-types-checking to its RUN statement. Thus you can obtain a regression test 'for free'.

ayartsev abandoned this revision.Feb 10 2017, 12:05 AM

Clone to D28187.