This is an archive of the discontinued LLVM Phabricator instance.

[StructurizeCFG] Use an inheriting constructor.
ClosedPublic

Authored by jlebar on Nov 22 2016, 1:45 PM.

Reviewers

Commits

jlebar retitled this revision from to [StructurizeCFG] Use an inheriting constructor..

jlebar updated this object.

jlebar added a reviewer: arsenm.

jlebar added a subscriber: llvm-commits.

LGTM. Could we just get rid of the argumentless one and use a default argument?

This revision is now accepted and ready to land.Nov 22 2016, 1:48 PM

Merge the two constructors into one.

Sure, done.

LGTM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Scalar/

9 lines

Show First 20 Lines • Show All 232 Lines • ▼ Show 20 Lines	class StructurizeCFG : public RegionPass {

void createFlow();		void createFlow();

void rebuildSSA();		void rebuildSSA();

public:		public:
static char ID;		static char ID;

StructurizeCFG() :		explicit StructurizeCFG(bool SkipUniformRegions = false)
RegionPass(ID), SkipUniformRegions(false) {		: RegionPass(ID), SkipUniformRegions(SkipUniformRegions) {
initializeStructurizeCFGPass(*PassRegistry::getPassRegistry());
}

StructurizeCFG(bool SkipUniformRegions) :
RegionPass(ID), SkipUniformRegions(SkipUniformRegions) {
initializeStructurizeCFGPass(*PassRegistry::getPassRegistry());		initializeStructurizeCFGPass(*PassRegistry::getPassRegistry());
}		}

using Pass::doInitialization;		using Pass::doInitialization;
bool doInitialization(Region *R, RGPassManager &RGM) override;		bool doInitialization(Region *R, RGPassManager &RGM) override;

bool runOnRegion(Region *R, RGPassManager &RGM) override;		bool runOnRegion(Region *R, RGPassManager &RGM) override;

▲ Show 20 Lines • Show All 729 Lines • Show Last 20 Lines