This is an archive of the discontinued LLVM Phabricator instance.

[mips] seb, seh instruction aliases
ClosedPublic

Authored by sdardis on Nov 22 2016, 3:25 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis updated this revision to Diff 78843.Nov 22 2016, 3:25 AM
sdardis retitled this revision from to [mips] seb, seh instruction aliases.
sdardis updated this object.
sdardis added a reviewer: vkalintiris.
sdardis set the repository for this revision to rL LLVM.
sdardis added a subscriber: llvm-commits.
vkalintiris accepted this revision.Nov 22 2016, 10:19 AM
vkalintiris edited edge metadata.

LGTM. I have one question/suggestion inline.

lib/Target/Mips/MicroMipsInstrInfo.td
1186–1189 ↗(On Diff #78843)

Shouldn't we use ISA_MIPS32R2_NOT_32R6_64R6 instead of ISA_MIPS1_NOT_32R6_64R6?

This revision is now accepted and ready to land.Nov 22 2016, 10:19 AM
sdardis marked an inline comment as done.Nov 22 2016, 11:02 AM
sdardis added inline comments.
lib/Target/Mips/MicroMipsInstrInfo.td
1186–1189 ↗(On Diff #78843)

Yeah, I'd missed that predicate during development.

This revision was automatically updated to reflect the committed changes.
sdardis marked an inline comment as done.

Thanks for the quick review.