Add missing unaligned store macros (ush/usw) and fix the exisiting
implementation of the unaligned load macros in order to generate
identical expansions with the GNU assembler.
Details
- Reviewers
sdardis
Diff Detail
- Build Status
Buildable 1367 Build 1367: arc lint + arc unit
Event Timeline
LGTM with some nits addressed, and another set of test cases.
I'm seeing differences between GAS' output and LLVM's output when the immediate has to be loaded with loadImmediate. The difference (extra moves) is mostly cosmetic and I am not too concerned with them.
lib/Target/Mips/AsmParser/MipsAsmParser.cpp | ||
---|---|---|
3325 | Nit, indentation. | |
3339–3340 | Restore this comment. | |
3375 | Nit, indentation. | |
3426 | Nit: indentation. | |
3473 | This should be using the register variant of 'or'. This is more for consistency with the GNU and LLVM toolchain for moving the contents of one register. Also, add test cases to cover this case: ulw $8, <cst>($8). | |
test/MC/Mips/mips-expansions.s | ||
692 | These moves aren't appearing from GAS' output. They're add's coming from loadImmediate. |
Nit, indentation.