Page MenuHomePhabricator

[analyzer] Rename assumeWithinInclusiveRange*()
ClosedPublic

Authored by ddcc on Nov 14 2016, 3:46 PM.

Details

Summary

The name is slightly confusing, since the constraint is not necessarily within the range unless Assumption is true. Split out renaming for ConstraintManager.h from D26061

Diff Detail

Repository
rL LLVM

Event Timeline

ddcc updated this revision to Diff 77901.Nov 14 2016, 3:46 PM
ddcc retitled this revision from to [analyzer] Rename assumeWithinInclusiveRange*().
ddcc updated this object.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
dcoughlin accepted this revision.Nov 14 2016, 4:02 PM
dcoughlin edited edge metadata.

LGTM, other then some indentation issues for arguments and parameters after the rename. Please fix those and commit! And thanks for splitting this up.

include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
103 ↗(On Diff #77901)

Nit: The indentation here (and elsewhere) is off after the rename.

This revision is now accepted and ready to land.Nov 14 2016, 4:02 PM
ddcc updated this revision to Diff 77930.Nov 14 2016, 6:02 PM
ddcc edited edge metadata.

Fix formatting

This revision was automatically updated to reflect the committed changes.