This is an archive of the discontinued LLVM Phabricator instance.

Differential D26640

Restore behavior broken by r286896 when Offset > 0 and !Data.empty()
AbandonedPublic

Authored by vitalybuka on Nov 14 2016, 2:44 PM.

Details

Reviewers
majnemer
zturner

Diff Detail

Event Timeline

vitalybuka updated this revision to Diff 77890.Nov 14 2016, 2:44 PM
vitalybuka retitled this revision from to Restore behavior broken by r286896 when Offset > 0 and !Data.empty().
vitalybuka updated this object.
vitalybuka added reviewers: zturner, majnemer.
vitalybuka added a subscriber: llvm-commits.
vitalybuka abandoned this revision.Nov 14 2016, 2:49 PM

Revision Contents

PathSize
include/
llvm/
DebugInfo/
MSF/
6 lines

Diff 77890

include/llvm/DebugInfo/MSF/ByteStream.h

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linespublic:
Error readLongestContiguousChunk(uint32_t Offset, Error readLongestContiguousChunk(uint32_t Offset,
ArrayRef<uint8_t> &Buffer) const override { ArrayRef<uint8_t> &Buffer) const override {
return ImmutableStream.readLongestContiguousChunk(Offset, Buffer); return ImmutableStream.readLongestContiguousChunk(Offset, Buffer);
} }
uint32_t getLength() const override { return ImmutableStream.getLength(); } uint32_t getLength() const override { return ImmutableStream.getLength(); }
Error writeBytes(uint32_t Offset, ArrayRef<uint8_t> Buffer) const override { Error writeBytes(uint32_t Offset, ArrayRef<uint8_t> Buffer) const override {
if (Buffer.empty())
return Error::success();
if (Data.size() < Buffer.size()) if (Data.size() < Buffer.size())
return make_error<MSFError>(msf_error_code::insufficient_buffer); return make_error<MSFError>(msf_error_code::insufficient_buffer);
if (Offset > Buffer.size() - Data.size()) if (Offset > Buffer.size() - Data.size())
return make_error<MSFError>(msf_error_code::insufficient_buffer); return make_error<MSFError>(msf_error_code::insufficient_buffer);
uint8_t *DataPtr = const_cast<uint8_t *>(Data.data()); uint8_t *DataPtr = const_cast<uint8_t *>(Data.data());
if (!Buffer.empty())
::memcpy(DataPtr + Offset, Buffer.data(), Buffer.size()); ::memcpy(DataPtr + Offset, Buffer.data(), Buffer.size());
return Error::success(); return Error::success();
} }
Error commit() const override { return Error::success(); } Error commit() const override { return Error::success(); }
MutableArrayRef<uint8_t> data() const { return Data; } MutableArrayRef<uint8_t> data() const { return Data; }
private: private:
▲ Show 20 Lines • Show All 54 Lines • Show Last 20 Lines