Page MenuHomePhabricator

add FreeBSD elf-core test
Needs ReviewPublic

Authored by emaste on Nov 14 2016, 9:42 AM.

Details

Reviewers
labath

Diff Detail

Event Timeline

emaste updated this revision to Diff 77827.Nov 14 2016, 9:42 AM
emaste retitled this revision from to add FreeBSD elf-core test.
emaste updated this object.
emaste added a reviewer: labath.
emaste added a subscriber: llvm-commits.
emaste added inline comments.Nov 14 2016, 9:50 AM
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
21–27

We'll probably want to rework these into a table of some sort, similar to

linux-i386, 32306, 32306, 4,
linux-x86_64, 32259, 32259, 5,
freebsd-x86_64, 0, 100283, 2,
29

I probably need to submit a PR for this (not extracting the pid from FreeBSD ELF cores) and reference it in a comment.

labath edited edge metadata.Nov 15 2016, 1:40 AM

Looks good. If we're going to put freebsd tests in the same file, we should rename the test file as well.

packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
21–27

Sounds good. Personally, I'd go for a two level structure data.linux_i386.pid or something like that.