This is an archive of the discontinued LLVM Phabricator instance.

[clang-move] Fix an incorrect range for the functions whose returned value is a macro
ClosedPublic

Authored by hokein on Nov 14 2016, 6:38 AM.

Details

Summary

Fix an incorrect range for the functions whose returned value is a macro
(e.g. bool). This incorrect range can lead to modifications of an unexpected
file where the macro is in.

We should use expansion location instead of spelling location.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein updated this revision to Diff 77806.Nov 14 2016, 6:38 AM
hokein retitled this revision from to [clang-move] Fix an incorrect range for the functions whose returned value is a macro.
hokein updated this object.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
ioeric accepted this revision.Nov 14 2016, 6:42 AM
ioeric edited edge metadata.

Lg.

Nice! Now I realize what I really meant was "ExpansionLoc" when I said "SpellingLoc" :P

This revision is now accepted and ready to land.Nov 14 2016, 6:42 AM
This revision was automatically updated to reflect the committed changes.