Page MenuHomePhabricator

Unify Darwin and Non-Darwin printing of version output
ClosedPublic

Authored by beanz on Nov 9 2016, 3:10 PM.

Details

Summary

This change unifies and simplifies the code paths between the Darwin and non-Darwin code to print the LLDB version information.

It also introduces a new variable in CMake LLDB_VERSION_STRING which can be used to specify custom version information.

With the LLDB_VERSION_STRING variable set to lldb-360.0.0, the -version output is:

./bin/lldb -version

lldb version 4.0.0 (lldb-360.0.0)

clang revision 286264
llvm revision 286265

This behavior is unified across all target platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 77403.Nov 9 2016, 3:10 PM
beanz retitled this revision from to Unify Darwin and Non-Darwin printing of version output.
beanz updated this object.
beanz added a reviewer: lldb-commits.
beanz added a subscriber: tfiala.
tfiala accepted this revision.Nov 9 2016, 3:26 PM
tfiala added a reviewer: tfiala.

Looks good, @beanz!

This revision is now accepted and ready to land.Nov 9 2016, 3:26 PM
This revision was automatically updated to reflect the committed changes.