This is an archive of the discontinued LLVM Phabricator instance.

Don't mark externally instantiated symbols as hidden
Needs ReviewPublic

Authored by EricWF on Nov 5 2016, 2:49 AM.

Details

Reviewers
mclow.lists
Summary

This is another possible fix for https://reviews.llvm.org/D25897.

I'm just putting this up for now so it's visible. I'll fill out the details later.

Diff Detail

Event Timeline

EricWF updated this revision to Diff 76966.Nov 5 2016, 2:49 AM
EricWF retitled this revision from to Don't mark externally instantiated symbols as hidden.
EricWF updated this object.
EricWF added a reviewer: mclow.lists.
EricWF updated this object.Nov 5 2016, 2:57 AM

The only [unrelated] problem I ran into was using the default options for -std. It was building with c++11 but testing with c++1z that was causing ifdef'd functions like the non-const copy of basic_string::data() to not be included in the libraries instantiation of the class.

Other than that minor hiccup, everything looks good to me. Thanks!

Any luck with this one? Anything else I can do to help out?