[clang-tidy] Fix a regression issue introduced by r285239.

[hokein]

Summary

r285239 changes the behavior of AST CXXDefaultArgExpr node.

Update modernize-use-nullptr to handle CXXDefaultArgExpr correctly.

[alexfh]

Thank you for tracking and fixing this! One nit inline.

clang-tidy/modernize/UseNullptrCheck.cpp

194 ↗

(On Diff #76920)

Use auto *.

clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp

bool TraverseStmt(Stmt *S) {
     }
     return RecursiveASTVisitor<CastSequenceVisitor>::TraverseStmt(S);
   }
 
   // Only VisitStmt is overridden as we shouldn't find other base AST types
   // within a cast expression.
   bool VisitStmt(Stmt *S) {
     CastExpr *C = dyn_cast<CastExpr>(S);
+    // Catch the castExpr inside cxxDefaultArgExpr.
+    if (auto *E = dyn_cast<CXXDefaultArgExpr>(S))
+      C = dyn_cast<CastExpr>(E->getExpr());
     if (!C) {
       FirstSubExpr = nullptr;
       return true;
     }
+
     if (!FirstSubExpr)
       FirstSubExpr = C->getSubExpr()->IgnoreParens();
 
+    // Ignore the expr if it is already a nullptr literal expr.
+    if (isa<CXXNullPtrLiteralExpr>(FirstSubExpr))
+      return true;
+
     if (C->getCastKind() != CK_NullToPointer &&
         C->getCastKind() != CK_NullToMemberPointer) {
       return true;
     }
 
     SourceLocation StartLoc = FirstSubExpr->getLocStart();
     SourceLocation EndLoc = FirstSubExpr->getLocEnd();
 

clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp

 char function(NoDef *p);
 #define F(x) (sizeof(function(x)) == 1)
 template<class T, T t>
 class C {};
 C<bool, F(0)> c;
 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: use nullptr
 // CHECK-FIXES: C<bool, F(nullptr)> c;
 #undef F
+
+// Test default argument expression.
+struct D {
+  explicit D(void *t, int *c = NULL) {}
+  // CHECK-MESSAGES: :[[@LINE-1]]:32: warning: use nullptr
+  // CHECK-FIXES: explicit D(void *t, int *c = nullptr) {}
+};
+
+void test_default_argument() {
+  D(nullptr);
+}