This is an archive of the discontinued LLVM Phabricator instance.

Differential D26286

[Sparc]: correct the ATOMIC_LLONG_LOCK_FREE macro
ClosedPublic

Authored by dougk on Nov 3 2016, 11:11 AM.

Details

Reviewers
jyknight
Commits
rG13f4a91a1fe9: [Sparc] LLONG is not lock-free atomic on v8
rC286376: [Sparc] LLONG is not lock-free atomic on v8
rL286376: [Sparc] LLONG is not lock-free atomic on v8

Diff Detail

Event Timeline

dougk updated this revision to Diff 76875.Nov 3 2016, 11:11 AM
dougk retitled this revision from to [Sparc]: correct the ATOMIC_LLONG_LOCK_FREE macro.
dougk updated this object.
dougk added a reviewer: jyknight.
dougk added a subscriber: cfe-commits.
dougk updated this revision to Diff 76879.Nov 3 2016, 12:24 PM

fix atomics-inlining test

jyknight accepted this revision.Nov 9 2016, 7:46 AM
jyknight edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2016, 7:46 AM
Closed by commit rL286376: [Sparc] LLONG is not lock-free atomic on v8 (authored by dougk). · Explain WhyNov 9 2016, 7:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Basic/
5 lines
test/
CodeGen/
13 lines
Preprocessor/
1 line

Diff 76879

lib/Basic/Targets.cpp

Context not available.
PtrDiffType = SignedLong; PtrDiffType = SignedLong;
break; break;
} }
MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; // Up to 32 bits are lock-free atomic, but we're willing to do atomic ops
// on up to 64 bits.
MaxAtomicPromoteWidth = 64;
MaxAtomicInlineWidth = 32;
} }
void getTargetDefines(const LangOptions &Opts, void getTargetDefines(const LangOptions &Opts,
Context not available.

test/CodeGen/atomics-inlining.c

Context not available.
// RUN: %clang_cc1 -triple powerpc64-linux-gnu -emit-llvm %s -o - | FileCheck %s -check-prefix=PPC64 // RUN: %clang_cc1 -triple powerpc64-linux-gnu -emit-llvm %s -o - | FileCheck %s -check-prefix=PPC64
// RUN: %clang_cc1 -triple mipsel-linux-gnu -emit-llvm %s -o - | FileCheck %s -check-prefix=MIPS32 // RUN: %clang_cc1 -triple mipsel-linux-gnu -emit-llvm %s -o - | FileCheck %s -check-prefix=MIPS32
// RUN: %clang_cc1 -triple mips64el-linux-gnu -emit-llvm %s -o - | FileCheck %s -check-prefix=MIPS64 // RUN: %clang_cc1 -triple mips64el-linux-gnu -emit-llvm %s -o - | FileCheck %s -check-prefix=MIPS64
// RUN: %clang_cc1 -triple sparc-unknown-eabi -emit-llvm %s -o - | FileCheck %s -check-prefix=SPARC // RUN: %clang_cc1 -triple sparc-unknown-eabi -emit-llvm %s -o - | FileCheck %s -check-prefix=SPARCV8 -check-prefix=SPARC
// RUN: %clang_cc1 -triple sparcv9-unknown-eabi -emit-llvm %s -o - | FileCheck %s -check-prefix=SPARCV9 -check-prefix=SPARC
unsigned char c1, c2; unsigned char c1, c2;
unsigned short s1, s2; unsigned short s1, s2;
Context not available.
// SPARC: store atomic i16 {{.*}}, i16* @s1 seq_cst // SPARC: store atomic i16 {{.*}}, i16* @s1 seq_cst
// SPARC: = load atomic i32, i32* @i1 seq_cst // SPARC: = load atomic i32, i32* @i1 seq_cst
// SPARC: store atomic i32 {{.*}}, i32* @i1 seq_cst // SPARC: store atomic i32 {{.*}}, i32* @i1 seq_cst
// SPARC: = load atomic i64, i64* @ll1 seq_cst // SPARCV8: call i64 @__atomic_load_8(i8* bitcast (i64* @ll1 to i8*)
// SPARC: store atomic i64 {{.*}}, i64* @ll1 seq_cst // SPARCV8: call void @__atomic_store_8(i8* bitcast (i64* @ll1 to i8*), i64
// SPARC: call void @__atomic_load(i32 100, i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a1, i32 0, i32 0), i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a2, i32 0, i32 0) // SPARCV9: load atomic i64, i64* @ll1 seq_cst, align 8
// SPARC: call void @__atomic_store(i32 100, i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a1, i32 0, i32 0), i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a2, i32 0, i32 0) // SPARCV9: store atomic i64 %7, i64* @ll1 seq_cst, align 8
// SPARCV8: call void @__atomic_load(i32 100, i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a1, i32 0, i32 0), i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a2, i32 0, i32 0)
// SPARCV8: call void @__atomic_store(i32 100, i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a1, i32 0, i32 0), i8* getelementptr inbounds ([100 x i8], [100 x i8]* @a2, i32 0, i32 0)
} }
Context not available.

test/Preprocessor/init.c

Context not available.
// SPARC:#define __FLT_MIN_EXP__ (-125) // SPARC:#define __FLT_MIN_EXP__ (-125)
// SPARC:#define __FLT_MIN__ 1.17549435e-38F // SPARC:#define __FLT_MIN__ 1.17549435e-38F
// SPARC:#define __FLT_RADIX__ 2 // SPARC:#define __FLT_RADIX__ 2
// SPARC:#define __GCC_ATOMIC_LLONG_LOCK_FREE 1
// SPARC:#define __INT16_C_SUFFIX__ // SPARC:#define __INT16_C_SUFFIX__
// SPARC:#define __INT16_FMTd__ "hd" // SPARC:#define __INT16_FMTd__ "hd"
// SPARC:#define __INT16_FMTi__ "hi" // SPARC:#define __INT16_FMTi__ "hi"
Context not available.