This is an archive of the discontinued LLVM Phabricator instance.

Differential D26260

Fix typo which broke debugging on older OSX systems after r285172.
ClosedPublic

Authored by dawn on Nov 2 2016, 2:02 PM.

Details

Reviewers
jasonmolenda
Commits
rG49df3895e74a: Fix typo which broke debugging on older OSX systems after r285172.
rLLDB285858: Fix typo which broke debugging on older OSX systems after r285172.
rL285858: Fix typo which broke debugging on older OSX systems after r285172.
Summary

Clearly ">=" was meant to be ">". :)

Diff Detail

Repository
rL LLVM

Event Timeline

dawn updated this revision to Diff 76780.Nov 2 2016, 2:02 PM
dawn retitled this revision from to Fix typo which broke debugging on older OSX systems after r285172..
dawn updated this object.
dawn added a reviewer: jasonmolenda.
dawn set the repository for this revision to rL LLVM.
dawn added a subscriber: lldb-commits.
jasonmolenda accepted this revision.Nov 2 2016, 2:03 PM
jasonmolenda edited edge metadata.

Yes it was, thanks for catching that! Please commit.

This revision is now accepted and ready to land.Nov 2 2016, 2:03 PM
Closed by commit rL285858: Fix typo which broke debugging on older OSX systems after r285172. (authored by dperchik). · Explain WhyNov 2 2016, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
source/
Plugins/
DynamicLoader/
MacOSX-DYLD/
2 lines

Diff 76780

source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp

Context not available.
// macOS 10.12 and newer // macOS 10.12 and newer
if (os_type == llvm::Triple::MacOSX && if (os_type == llvm::Triple::MacOSX &&
(major >= 10 || (major == 10 && minor >= 12))) { (major > 10 || (major == 10 && minor >= 12))) {
use_new_spi_interface = true; use_new_spi_interface = true;
} }
Context not available.