Page MenuHomePhabricator

Minidump plugin: Fix flaky test
ClosedPublic

Authored by dvlahovski on Nov 1 2016, 8:32 AM.

Details

Summary

One of the tests was flaky, because similarly to
https://reviews.llvm.org/D18697 (rL265391) - if there is a process running
which is with the same PID as in the core file, the minidump
core file debugging will fail, because we get some information from the
running process.
The fix is routing the ProcessInfo requests through the Process class
and overriding it in ProcessMinidump to return correct data.

Diff Detail

Repository
rL LLVM

Event Timeline

dvlahovski updated this revision to Diff 76560.Nov 1 2016, 8:32 AM
dvlahovski retitled this revision from to Minidump plugin: Fix flaky test.
dvlahovski updated this object.
dvlahovski added a reviewer: labath.
dvlahovski added subscribers: beanz, lldb-commits.
labath accepted this revision.Nov 1 2016, 8:39 AM
labath edited edge metadata.

lgtm

This revision is now accepted and ready to land.Nov 1 2016, 8:39 AM
This revision was automatically updated to reflect the committed changes.