Page MenuHomePhabricator

[InstCombine] Add tests to demo generation of potentially illegal integer widths.
ClosedPublic

Authored by bryant on Oct 25 2016, 11:08 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

bryant updated this revision to Diff 75738.Oct 25 2016, 11:08 AM
bryant retitled this revision from to [InstCombine] Add tests to demo generation of potentially illegal integer widths..
bryant updated this object.
bryant added a reviewer: spatel.
bryant set the repository for this revision to rL LLVM.
bryant added a subscriber: llvm-commits.
spatel accepted this revision.Oct 25 2016, 11:23 AM
spatel edited edge metadata.

LGTM.

Note that I added a non-NUW test that would survive D25913 in rL285075.

When committing, I'd re-title this to something like "add tests for missing icmp + shl nuw fold".

This revision is now accepted and ready to land.Oct 25 2016, 11:23 AM

LGTM.

Note that I added a non-NUW test that would survive D25913 in rL285075.

Yes, I saw this commit while rebasing. I'll be posting my fix in a forthcoming Phab thread.

When committing, I'd re-title this to something like "add tests for missing icmp + shl nuw fold".

I don't have commit access, so you'll have to commit.

This revision was automatically updated to reflect the committed changes.