Page MenuHomePhabricator

Analysis: Move llvm::getConstantRangeFromMetadata to IR library.
ClosedPublic

Authored by pcc on Oct 21 2016, 12:46 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 75463.Oct 21 2016, 12:46 PM
pcc retitled this revision from to Analysis: Move llvm::getConstantRangeFromMetadata to IR library..
pcc updated this object.
pcc added a reviewer: sanjoy.
pcc added a subscriber: llvm-commits.
sanjoy accepted this revision.Oct 21 2016, 12:55 PM
sanjoy edited edge metadata.

lgtm with nits

llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
18 ↗(On Diff #75463)

Does this still need to include ValueTracking?

llvm/lib/Transforms/Scalar/GuardWidening.cpp
48 ↗(On Diff #75463)

Does this still need to include ValueTracking?

This revision is now accepted and ready to land.Oct 21 2016, 12:55 PM
pcc added inline comments.Oct 21 2016, 1:01 PM
llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
18 ↗(On Diff #75463)

It doesn't currently do so :)

llvm/lib/Transforms/Scalar/GuardWidening.cpp
48 ↗(On Diff #75463)

Yes, we use (e.g.) isSafeToSpeculativelyExecute here.

This revision was automatically updated to reflect the committed changes.