This is an archive of the discontinued LLVM Phabricator instance.

[MC] Make llvm-mc fail cleanly on invalid output asm variant.
ClosedPublic

Authored by niravd on Oct 20 2016, 11:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

niravd updated this revision to Diff 75322.Oct 20 2016, 11:12 AM
niravd retitled this revision from to [MC] Make llvm-mc fail cleanly on invalid output asm variant..
niravd updated this object.
niravd added reviewers: rnk, majnemer.
niravd added a subscriber: llvm-commits.
rnk added inline comments.Oct 28 2016, 1:12 PM
tools/llvm-mc/llvm-mc.cpp
567–568 ↗(On Diff #75322)

I think this can fail for other reasons, such as the target not having an MCInstPrinter. I'd give a more generic error message, like "unable to create instruction printer for assembly variant N of target triple foo"

niravd updated this revision to Diff 76422.Oct 31 2016, 9:13 AM

Changed error message.

rnk accepted this revision.Oct 31 2016, 9:29 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Oct 31 2016, 9:29 AM
This revision was automatically updated to reflect the committed changes.