Details
- Reviewers
chrisj
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Analysis/ScopInfo.cpp | ||
---|---|---|
2795 | I think we can return false right after "BranchInst *BI = dyn_cast<BranchInst>(TI);" if BI is nullptr. |
lib/Analysis/ScopInfo.cpp | ||
---|---|---|
2798–2799 | If I see correctly, this also fixes a leak? Does this mean in none of our tests buildConditionSets returns false because ISL would have noticed leaked objects? |
Yes, it seems there is indeed a leak. I remember I saw it in my static analysis run, but did not get to report it:
lib/Analysis/ScopInfo.cpp | ||
---|---|---|
2795 | @zinob Please add the full diff context so people can see surrounding code and notice that the !BI check is already performed 4 lines prior [In the else case BI is not null]. |
This has been resolved in r286426 "Do not allow switch statements in loop latches". I cannot close this myself. Zino can you please close.