When invoking Terminal, don't assume the default shell

[beanz]

Summary

If a user has their shell set to a non-POSIX conferment shell the TestTerminal.py tests fail because the shell blurb constructed here may not work in their shell.

In my specific case fish-shell (The Friendly Interactive Shell - http://fishshell.com) does not support $?, it instead uses $status (because it is friendly).

This patch removes the assumption of your default shell by running the constructed bash command via "/bin/bash -c ...". This should be safer for users mutating their shell environment.

[tfiala]

Yep, looks right. We shouldn't be assuming the shell.

[joerg]

Hard-coding /bin/bash is not an improvement in my opinion. There are quite a few systems where this is plainly breaking things.

[joerg]

OK, this is OSX specific, but I still think that hardcoding bash is a bad idea. Does it need anything not in /bin/sh?

[beanz]

@joerg, it is OS X exclusive, and bash is the system default shell, so I think that makes sense.

source/Host/macosx/Host.mm

 //        Host::ThreadCancel (accept_thread, &lldb_error);
 //    }
 //
 //    return pid;
 //}
 
 const char *applscript_in_new_tty = "tell application \"Terminal\"\n"
                                     "   activate\n"
-                                    "  do script \"%s\"\n"
+                                    "  do script \"/bin/bash -c '%s';exit\"\n"
                                     "end tell\n";
 
 const char *applscript_in_existing_tty = "\
-set the_shell_script to \"%s\"\n\
+set the_shell_script to \"/bin/bash -c '%s';exit\"\n\
 tell application \"Terminal\"\n\
   repeat with the_window in (get windows)\n\
     repeat with the_tab in tabs of the_window\n\
       set the_tty to tty in the_tab\n\
       if the_tty contains \"%s\" then\n\
         if the_tab is not busy then\n\
           set selected of the_tab to true\n\
           set frontmost of the_window to true\n\